Ticket #4522 (closed defect (bug): fixed)

Opened 5 years ago

Last modified 5 years ago

Template: default broken

Reported by: sunburntkamel Owned by: anonymous
Priority: normal Milestone: 2.2.2
Component: Template Version: 2.2.1
Severity: normal Keywords: has-patch theme template linebreaks
Cc: scottwallick, dougal

Description

in 2.2.1, and all versions of newer than r5630, using template: to create stylesheet based themes is broken (i.e.  http://codex.wordpress.org/Theme_Development#Theme_Style_Sheet )

every server configuration i've tried (WAMP, LAMP, PHP 5), others reporting the same problem.

diff that caused the issue:  http://trac.wordpress.org/changeset?old_path=trunk%2Fwp-includes%2Ftheme.php&old=5630&new_path=trunk%2Fwp-includes%2Ftheme.php&new=5747

Attachments

theme.php.diff Download (339 bytes) - added by dougal 5 years ago.
patch against 2.2.1 wp-includes/theme.php

Change History

comment:1   scottwallick — 5 years ago

It seems that there were line breaks introduced in themes.php post-r5620 that caused this problem.

Also breaks in my configs as well, but r5630 works fine.

dougal — 5 years ago

patch against 2.2.1 wp-includes/theme.php

comment:2   dougal — 5 years ago

  • Cc dougal added
  • Keywords has-patch added

Yup, definitely broken in 2.2.1. There is no handling of the $template variable (which is to say, it remains an array as returned from the preg_match when parsing the template metadata). Patch attached.

comment:3   markjaquith — 5 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [5770]) Fix stylesheet-based themes. props dougal. fixes #4522

Note: See TracTickets for help on using tickets.