Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#45574 closed enhancement (fixed)

"WordPress 5.0" is available link goes to uninformative page

Reported by: brentswisher's profile brentswisher Owned by: pento's profile pento
Milestone: 5.1 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-patch needs-testing commit
Focuses: Cc:

Description

When viewing a site that has not updated to 5.0, the "update nag" link goes to https://codex.wordpress.org/Version_5.0 which is not a very informative page, it essentially just links to https://wordpress.org/support/wordpress-version/version-5-0/

Is there any reason not to link right to the support page from the admin?

Attachments (2)

Dashboard_‹_Brent_Swisher_—_WordPress.png (17.8 KB) - added by brentswisher 5 years ago.
Screenshot of link location
45574.diff (11.3 KB) - added by swissspidy 5 years ago.

Download all attachments as: .zip

Change History (13)

@brentswisher
5 years ago

Screenshot of link location

#1 @subrataemfluence
5 years ago

  • Resolution set to invalid
  • Status changed from new to closed
  • Type changed from defect (bug) to enhancement

Welcome to Trac and thanks for the ticket!

The link goes to a codes page where you have the actual information page link available, i.e. https://wordpress.org/support/wordpress-version/version-5-0/.

Unlike 4.9.8, probably 5.0 does not have the documentation completed yet and so it encourages users to navigate to the above link.

Since all WordPress versions by default have a landing codex page with information furnished, it is good to have that page in place for 5.0 as well (although it is not completed yet) along with a link to navigate to the actual information page.

I am quite sure, in due course, as the documentation completes, the codex page will have them.

#2 @swissspidy
5 years ago

  • Milestone changed from Awaiting Review to 5.0.2
  • Resolution invalid deleted
  • Status changed from closed to reopened

Actually, with the migration from the Codex to HelpHub we should probably update the URLs in the update_nag() function accordingly.

#3 @swissspidy
5 years ago

  • Keywords has-patch added

@swissspidy
5 years ago

#4 @swissspidy
5 years ago

  • Keywords needs-testing added

This ticket was mentioned in Slack in #docs by swissspidy. View the logs.


5 years ago

#6 @pento
5 years ago

  • Milestone changed from 5.0.2 to 5.0.3

#7 @audrasjb
5 years ago

  • Keywords commit added

Hi,

I tested the patch and it works fine on my side with both 5.0.x and 4.9.8/9 versions.

Adding commit tag to see if it can land in 5.0.3.

#8 @desrosj
5 years ago

  • Milestone changed from 5.0.3 to 5.1

This falls outside of the 5.0.3 scope. Punting to 5.1.

#9 @pento
5 years ago

  • Owner set to pento
  • Status changed from reopened to assigned

#10 @pento
5 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 44451:

Install/Upgrade: Link to HelpHub instead of the Codex.

WordPress version links in the Codex (eg, https://codex.wordpress.org/Version_5.0) are redirected to their HelpHub equivalent.

Rather than relying on the redirect, Core and link directly to HelpHub.

Props swissspidy.
Fixes #45574.

#11 @ocean90
5 years ago

In 44700:

Install/Upgrade: After [44451], update translator comments to include the new placeholder.

See #46111.
Fixes #45574.

Note: See TracTickets for help on using tickets.