Opened 6 years ago

Closed 6 years ago

#4618 closed defect (bug) (fixed)

Last-modified header on comments feed is updated before comments are approved

Reported by: hendry Owned by: anonymous
Priority: normal Milestone: 2.3
Component: Administration Version: 2.0.10
Severity: normal Keywords: has-patch
Cc:

Description

​http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=428844

There is a patch attached to the bug in the Debian bts.

Attachments (2)

4618_20.diff​ (1.6 KB) - added by Nazgul 6 years ago.
4618_trunk.diff​ (1.6 KB) - added by Nazgul 6 years ago.

Download all attachments as: .zip

Change History (9)

Nazgul — 6 years ago

Nazgul — 6 years ago

comment:1   Nazgul — 6 years ago

  • Keywords has-patch added; patch removed

The given patch failed to apply for me, so I recreated it. (Could be a TortoiseSVN issue on my side though)

I also made a patch for trunk.

comment:2   ryan — 6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5885]) Don't update comments feed last-modified header for unapproved comments. Props James Ballantine and Nazgul. fixes #4618 for 2.3

comment:3   ryan — 6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopened for 2.0 consideration.

comment:4   Nazgul — 6 years ago

  • Milestone changed from 2.0.12 to 2.0.eventually

comment:5   Nazgul — 6 years ago

  • Milestone 2.0.eventually deleted
  • Resolution set to wontfix
  • Status changed from reopened to closed

Closing as wontfix for the 2.0 branch.

MarkJaquith has stated that only security fixes can go into the 2.0 branch.

comment:6   foolswisdom — 6 years ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened

comment:7   foolswisdom — 6 years ago

  • Milestone set to 2.3
  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.