Ticket #4639 (closed defect (bug): fixed)
action admin_print_scripts- isnt fired for plugins which reside in a subdir.
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 2.3 |
| Component: | Administration | Version: | 2.3 |
| Severity: | normal | Keywords: | admin_print_scripts get_plugin_page_hook has-patch |
| Cc: |
Description
admin-header.php:
if ( isset($page_hook) )
do_action('admin_print_scripts-' . $page_hook);
else if ( isset($plugin_page) )
do_action('admin_print_scripts-' . $plugin_page);
For plugins which reside in a subdirectory (ie. /wp-content/plugins/plugin_name/plugin.php), the admin_print_scripts- action doesnt fire, The problem is that $page_hook is a 0 character string, however IS set.
Theres 2 options i can see, correcting the function which assigns to $page_hook, or testing for isset() && ! empty()
Attached is a patch to modify get_plugin_page_hook() to return null insead of , this causes $page_hook to "not be set" which in turn, causes the print scripts hook to correctly run.
Attachments
Change History
-
attachment
4639.get_plugin_page_hook.patch
added
-
attachment
4639.get_plugin_page_hook.diff
added
get_plugin_page_hook fix as diff instead
- Keywords admin_print_scripts get_plugin_page_hook added
Apologies for the 2 different format patches/diffs, the HTML viewer didnt work for the .patch file, so i thought it only accepted .diff, but that isnt working either.

get_plugin_page_hook fix