permalink_single_rss needs a filter

[joostdevalk]

summary says it all, you can't filter the output of permalink_single_rss

Patch

+1 to adding a filter specifically for the rss permalink output.

But why is it called permalink_single_rss() anyway? Wouldn't the_permalink_rss() make more sense? Suggest renaming this function and all the calls to it.

Adding the filter is obviously a no brainer as for renaming - it is a published template tag so we would need to retain the old version in deprecated.php for a while.

I'm not sure the rename is worth it.

What does everyone else think?

I'm +1 for renaming, for consistnecies sake. We use the the_xxx format almost everywhere, so we should do it here as well.

That patch can be made a lot simpler, too, into one line.

Deprecate permalink_single_rss, replace with the_permalink_rss. Also adds the_permalink_rss filter.

Added my patch suggestion. Sorry for the excessive whitespace changes in the patch, there's a lot of whitespace at the end of lines that my editor removes whenever I edit a PHP file.

What else needs done before this can get committed?

Wait for it. We sometimes use the 'commit' keyword, but I'm not sure if the developers use that or not.

Otto42, could you deactivate that whitespace cleanup feature of your text editor before creating patches? I'm a big fan of cleanup, but when it's mixed in with functional changes, it makes it really hard to see what has changed. I'd rather have condensed functional diffs and then separate whitespace cleanup diffs.

And yes, I know I've been guilty of this too in the past. :-)

(In [5910]) Deprecate permalink_single_rss(). Add the_permalink_rss() with accompanying filter. Props joostdevalk and Otto42. fixes #4654