Opened 6 years ago

Closed 6 years ago

#4706 closed defect (bug) (fixed)

"You should update your .htaccess now." message appears even for non-mod_rewrite permalink structures

Reported by: markjaquith Owned by: anonymous
Priority: normal Milestone: 2.3
Component: Administration Version: 2.3
Severity: normal Keywords:
Cc:

Description

Setting permalink structure as:

/index.php/%year%/%monthnum%/%day%/%postname%/

The following message is shown on update:

You should update your .htaccess now.

No code for .htaccess is provided (because I've chosen a non-mod_rewrite structure).

Attachments (1)

4706.001.diff​ (571 bytes) - added by markjaquith 6 years ago.
Better logic

Download all attachments as: .zip

Change History (4)

markjaquith — 6 years ago

Better logic

comment:1   markjaquith — 6 years ago

There's a patch. Now it uses the logic like from the bottom of options-permalink.php where it decides whether or not to echo out the .htaccess code.

comment:2   JeremyVisser — 6 years ago

Also, on WordPress MU, will this stop the 'You should update your .htaccess now.' message when a measly user updates their permalink structure?

comment:3   markjaquith — 6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5854]) Don't tell users they have to update their .htaccess unless we're actually giving them something with which to update it. fixes #4706

Note: See TracTickets for help on using tickets.