Ticket #4741 (closed defect (bug): fixed)

Opened 4 years ago

Last modified 4 years ago

Multiple $wp_query objects mess a lot of things up

Reported by: mdawaffe Owned by: anonymous
Priority: normal Milestone: 2.3
Component: Administration Version: 2.2.2
Severity: normal Keywords:
Cc:

Description

Many themes call query_posts() one or more times, each overwriting the previous $wp_query object. Unless we're super careful, this can break a lot of stuff. To get back to the original query, I find myself doing

$GLOBALS['wp_query'] = $GLOBALS['wp_the_query'];

a lot.

I propose a new wp_reset_query() function that replaces $wp_query with the original $wp_the_query. It might prove useful to attach that function to the wp_footer action. It'd probably actually fix a lot of custom stuff out there that no one knew was broken, but it'd likely also break a few things for people.

Attached adds the function and no more.

Attachments

4741.diff Download (399 bytes) - added by mdawaffe 4 years ago.

Change History

+1

This sounds like a really useful function.

comment:3   ryan4 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [5907]) wp_reset_query() from mdawaffe. fixes #4741

Note: See TracTickets for help on using tickets.