new function: absint()

[markjaquith]

There were a few bugs whereby things were being cast to ints and providing a negative int would mess up a query (for instance, with SQL LIMITs). We accept negative ints for post IDs (temporarily), but in all other places that Matt or I could think of, we use positive integers.

function absint($string) {
	return abs(intval($string));
}

We'd then convert all instances of intval() or (int) casting to use absint() (minus post IDs).

Objections? Thoughts?

+1 megapatch.

(In [6222]) Introducing absint() for casting to an absolute integer. see #4762

Re-opening for markjaquith to close. He might be planning on using that function before closing this ticket.

Replying to lloydbudd:

Re-opening for markjaquith to close. He might be planning on using that function before closing this ticket.

Apologies for stepping on anyones toes.

absint() has been put into use in several places (comment/post/taxonomy/functions .php)

(In [6682]) Switch from abs(intval()) to absint(). See #4762.

Changeset 6682 breaks AtomPub:

​http://intertwingly.net/stories/2007/11/ape/report.html#dia-1

absint doesn't exist yet

The absint() function doesn't exist this early, so need to use abs(intval()).

While there, made both sides of the comparison to use abs(intval()) for identical treatment of the non-integer values (e.g. 8M or 32M).

Err, "this early" == in wp-settings.php

(In [6684]) absint is not defined yet. see #4762

Replying to ryan:

(In [6684]) absint is not defined yet. see #4762

/me slaps wrist... that what I get for doing the change when I'm tired :-(

The only place we don't use this now where we have abs(intval()) instead is in wp-settings.php where it is too early and not defined.

There are a number of places where we only use intval() though but these need to be checked carefully so moving to 2.6 for the remaining changes and marking as needs-patch

could we close this one as fixed?

fixed a while ago