Ticket #4770 (closed defect (bug): fixed)

Opened 4 years ago

Last modified 4 years ago

Fix mt_allow_pings in metaWeblog.newPost (XML-RPC)

Reported by: josephscott Owned by: anonymous
Priority: normal Milestone: 2.2.3
Component: Administration Version:
Severity: normal Keywords: xml-rpc has-patch
Cc: josephscott

Description

There is typo in mw_newPost() that prevents mt_allow_pings from being picked up properly. I've got a patch that fixes this.

A big thank you to Allan Odgaard for pointing this out and not giving up this.

Attachments

ping-xmlrpc.php.diff Download (1.2 KB) - added by josephscott 4 years ago.
fix another typo in metaWeblog.editPost and remove duplicate code.
ping-22-xmlrpc.php.diff Download (725 bytes) - added by josephscott 4 years ago.

Change History

josephscott — 4 years ago

fix another typo in metaWeblog.editPost and remove duplicate code.

comment:1   josephscott — 4 years ago

The updated patch now takes care of both typos and removes some duplicate code that was trying to process mt_allow_pings a second time in metaWeblog.editPost.

comment:2   ryan — 4 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [5898]) mt_allow_pings fix. Props Joseph Scott and Allan Odgaard. fixes #4770 for 2.3

comment:3   ryan — 4 years ago

Fixed for 2.3. Needed for 2.2?

josephscott — 4 years ago

comment:4   josephscott — 4 years ago

Yes, 2.2 has the same issue. The patch is a little different, provided above as ping-22-xmlrpc.php.diff.

comment:5   josephscott — 4 years ago

  • Status changed from closed to reopened
  • Resolution fixed deleted
  • Milestone changed from 2.3 (trunk) to 2.2.3

comment:6   ryan — 4 years ago

  • Status changed from reopened to closed
  • Resolution set to fixed

(In [5905]) mt_allow_pings fix. Props Joseph Scott and Allan Odgaard. fixes #4770 for 2.2

Note: See TracTickets for help on using tickets.