WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#4835 closed enhancement (fixed)

Update notification i18n improvements

Reported by: nbachiyski Owned by: anonymous
Priority: lowest Milestone:
Component: I18N Version:
Severity: trivial Keywords: 2nd-opinion
Cc:

Description

  • Split into more translatable phrases
  • Allow translators to change the urls in the footer, documentation and feedback forums can be different for local versions

Attachments (1)

updater.diff (2.2 KB) - added by nbachiyski 6 years ago.

Download all attachments as: .zip

Change History (9)

nbachiyski6 years ago

comment:1 Viper007Bond6 years ago

Not sure if I like localizations of WordPress being able to change the URLs in the footer. What's to say one unofficial WP support site is better than the other?

ex: say there are two Italian WordPress support sites. Who's to pick which is the better and which should be linked to in the official Italian translation?

comment:2 follow-up: leonid6 years ago

Those people who do WordPress support for their clients might want to use a different URL (ticketing system/local forum), or remove it altogether. The easier it is to change, the better.

comment:3 ryan6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [5955]) Gettext fixes from nbachiyski. fixes #4835

comment:4 in reply to: ↑ 2 Viper007Bond6 years ago

Replying to leonid:

Those people who do WordPress support for their clients might want to use a different URL (ticketing system/local forum), or remove it altogether. The easier it is to change, the better.

Then that would be the purpose of a filter, not localization.

comment:5 Viper007Bond6 years ago

  • Keywords 2nd-opinion added; i18n removed
  • Priority changed from low to lowest
  • Resolution fixed deleted
  • Severity changed from minor to trivial
  • Status changed from closed to reopened

I hate to be a pest, but I still think is a bad patch in terms of the URLs.

If we need to update these URLs later (say the support forums), we would need to generate whole new strings for translation. If the translator feels they need to change all of the URLs for some reason, then they can simple replace the %s' with URLs with no ill effects. Not to mention it's just bad form IMO.

Or is there something I'm missing? I'm the first to admit that I'm no i18n expert.

comment:6 nbachiyski6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

Yes, if they replace an %s with the string they want will happily work in PHP, but the gettext tools won't allow you to compile a mo file if you have skipped a format specifier -- it is considered a syntax error.

comment:7 nbachiyski6 years ago

  • Milestone 2.3 deleted
  • Version 2.3 deleted
Note: See TracTickets for help on using tickets.