Ticket #5080 (closed defect (bug): fixed)

Opened 4 years ago

Last modified 4 years ago

image title still borked

Reported by: tellyworth Owned by: anonymous
Priority: normal Milestone: 2.3.1
Component: General Version: 2.3
Severity: normal Keywords: has-patch 2nd-opinion
Cc:

Description

  1. New Post
  1. Upload a PDF file, leave Title blank
  1. Click Send To Editor - it fails silently

The enclosed patch uses the filename as link text if the title is blank. It also fixes image uploads where 'Show: Title' is selected and the title is blank.

Attachments

upload-title-fix-r6168.patch Download (405 bytes) - added by tellyworth 4 years ago.

Change History

tellyworth — 4 years ago

comment:1   Viper007Bond — 4 years ago

  • Keywords has-patch 2nd-opinion added
  • Version set to 2.3
  • Milestone changed from 2.5 to 2.3.1

comment:2   ryan — 4 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [6234]) Use filename if no title. Props tellyworth. fixes #5080 for 2.3

comment:3   ryan — 4 years ago

(In [6235]) Use filename if no title. Props tellyworth. fixes #5080 for trunk

comment:4   tgiokdi — 4 years ago

  • Status changed from closed to reopened
  • Resolution fixed deleted
  • Summary changed from Send To Editor fails if title is empty to image title still borked

fixed the pdf bug, but didn't effect the image title situation. Uploading an image without a title produces a non-working link for the "link to page" option.

comment:5   darkdragon — 4 years ago

  • Status changed from reopened to closed
  • Resolution set to fixed

I would make a new patch it is causing issues for images.

comment:6   darkdragon — 4 years ago

I meant make a new ticket, if it is still broken for images.

Note: See TracTickets for help on using tickets.