Patch prevents an Undefined Variable error in get_attachment_icon()

[richcon]

The included patch prevents an Undefined Variable E_NOTICE error from being triggered in get_attachment_icon()
(wp-includes/post-template.php)

On line 453:

$icon = "<img src='$src' title='$post_title' alt='$post_title' $constraint/>";

the variable $constraint is not defined if the icon's image fits within the allowed size.

Patch to wp-includes/post-template.php

(In [6201]) Define $constaint is all cases in get_attachment_icon() to fix E_NOTICE. Fixed #5159 props richcon.

Reopening for 2.3.1 consideration.

Replying to westi:

Reopening for 2.3.1 consideration.

My personal opinion is that notice fixes are not severe enough to warrant fixing in a maintenance release.