Ticket #5173 (closed enhancement: fixed)

Opened 4 years ago

Last modified 4 years ago

Replace get_category_rss_link with get_category_feed_link

Reported by: ionfish Owned by: anonymous
Priority: normal Milestone: 2.5
Component: Template Version: 2.3
Severity: normal Keywords: needs-patch
Cc:

Description

Replacing get_category_rss_link with a get_category_feed_link function would allow theme authors to use WordPress's Atom feeds instead, if they prefer. get_category_rss_link would be deprecated, but not removed, to keep backwards compatibility with themes which use it.

Attachments

getcatfeedlink.diff Download (1.4 KB) - added by ionfish 4 years ago.

Change History

  • Keywords has-patch added
  • Milestone set to 2.4
  • Keywords needs-patch added; has-patch removed

+1 on the idea. But the patch only addresses default permalinks. People with pretty permalinks wouldn't get the feed type they asked for.

Good point. I'll tweak the patch. I was also thinking of doing the same for get_author_rss_link, should I add that to this ticket or make a new one?

comment:4   ryan4 years ago

Look at get_tag_feed_link() and pattern get_category_feed_link() after it. We don't really need to pass the nicename and echo.

More like it? :)

Getting better. On line 150, you need to trailingslashit($link) (like on the old line 138). Otherwise, you could get:

 http://example.com/category/foofeed/atom

ionfish4 years ago

Any chance of another look-over?

comment:8   ryan4 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [6327]) get_category_feed_link() from ionfish. fixes #5173

comment:9   ryan4 years ago

(In [6328]) phpdoc for get_category_feed_link(). see #5173

Note: See TracTickets for help on using tickets.