Ticket #5240 (closed defect (bug): fixed)

Opened 4 years ago

Last modified 4 years ago

taxonomy - incorrect query in update or insert term to increase term_group

Reported by: michelwp Owned by: anonymous
Priority: high Milestone: 2.5
Component: Administration Version: 2.3
Severity: major Keywords: taxonomy term slug term_group alias_of needs-patch
Cc:

Description

In both functions (wp_insert_term and wp_update_term, the SQL query - to increase the term_group when creating an alias of a term not yet in a term_group - is incorrect.

The query was 

SELECT MAX(term_group) FROM $wpdb->terms GROUP BY term_group

but must be 

SELECT MAX(term_group) FROM $wpdb->terms

GROUP BY is not here necessary !

(I am testing taxonomy.php script and features to create a multilingual dictionary of terms that can be used in themes or elsewhere)

About alias_of features : See also Trac #5230

Attachments

taxonomy_diffs Download (2.0 KB) - added by michelwp 4 years ago.

Change History

michelwp — 4 years ago

comment:1   michelwp — 4 years ago

Please find enclose the comparison of taxonomy in diff (I found a easy way to make it) between 2.3 original (_o) and the current running on our public test web site dev.xiligroup.com... (it is summary of #5230 and this one #5240). Michel

comment:2   ryan — 4 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [6285]) Remove unnecessary GROUP BY when getting max term_group. Props michelwp. fixes #5240

Note: See TracTickets for help on using tickets.