Opened 6 years ago

Closed 5 years ago

#5247 closed enhancement (fixed)

comments_popup_link needs a filter

Reported by: joostdevalk Owned by: anonymous
Priority: normal Milestone: 2.5
Component: General Version: 2.3
Severity: normal Keywords: needs-testing has-patch
Cc: joostdevalk

Description

To be able to add additional stuff to the comments_popup_link (like rel="nofollow"), the output of this function should be filtered.

Attachments (1)

commentspopuplink.patch​ (1.5 KB) - added by joostdevalk 5 years ago.
Patch

Download all attachments as: .zip

Change History (5)

joostdevalk — 5 years ago

Patch

comment:1   joostdevalk — 5 years ago

  • Keywords needs-testing has-patch added

comment:2   ryan — 5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6368]) comments_popup_link filter from joostdevalk. fixes #5247

comment:3   matt — 5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

joostdevalk, please check your patches more carefully. This causes visible brokenness on the front page of anyone who uses it.

comment:4   matt — 5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

(In [6372]) Revert [6368]. Fixes #5448, fixes #5247 by adding a new filter to hook in specifically to add attributes, rather than filtering the whole thing. Minor formatting cleanup of comments_popup_link.

Note: See TracTickets for help on using tickets.