Ticket #5312 (closed enhancement: fixed)

Opened 2 years ago

Last modified 2 years ago

wp-admin/includes/image.php overhaul

Reported by: DD32 Owned by: westi
Priority: normal Milestone: 2.5
Component: Administration Version: 2.5
Severity: normal Keywords: has-patch
Cc:

Description

This ticket relates to #4151, #4709 and #5304

I've cleaned the file up to reduce duplicated code, Added PHPDoc comments, and included mentioned tickets within the cleanup.

Notes:
* function get_udims() duplicated wp_shrink_dimensions(), Switched it to use wp_shrink_dimensions() instead.
* It appears that get_udims() is not used anywhere else in WP.
* depreciated 3rd param($effect) to wp_create_thumbnail() as it isnt used within the function.
* IMAGETYPE_XXX introduced with PHP 4.3.0 it appears, Added to compat.php.
* The inline documentation may not be the best, And doesnt include Long descriptions for most of the functions.
* Most functions should return a WP_Error object instead on error, For most compatibilit current patch follows previous error handling route.

Attachments

5312.diff Download (11.1 KB) - added by DD32 2 years ago.
image.php cleanup

Change History

DD322 years ago

image.php cleanup

westi2 years ago
  • owner changed from anonymous to westi
  • status changed from new to assigned

westi2 years ago
  • status changed from assigned to closed
  • resolution set to fixed

(In [6309]) Refactor of wp-admin/includes/image.php. Fixes #5312, #4151, #4709, #5304 props DD32.

Note: See TracTickets for help on using tickets.