Ticket #5366 (closed defect (bug): fixed)

Opened 4 years ago

Last modified 4 years ago

XMLRPC interface misinterprets mt_allow_comments value

Reported by: redsweater Owned by: josephscott
Priority: normal Milestone: 2.5
Component: XML-RPC Version: 2.3.1
Severity: normal Keywords:
Cc: redsweater, josephscott

Description

WordPress's XMLRPC interface makes an understandable mistake when interpreting the mt_allow_comments field.

The field as described and used by MovableType and others is actually a ternary value with integer values meaning:

0 - None - No comments allowed 1 - Open - Comments can be read and write 2 - Closed - Comments can be read but not written

WordPress doesn't have a notion of "read-only comments" but it needs to do something accurate when the "2" (closed) value is passed to the XMLRPC interface.

Right now what it does is fail to recognize 2 as a valid input, and defaults to the system default comment status.

I believe it should map "2" -> "closed" so that the expected behavior of halting further comments is obtained by the user. The typical scenario now is that the blog defaults to "open" comments, so when a user of a client application specifies "closed" for the comment status, the server defaults it back to "open" ... exactly the opposite of the user's desire.

Attachments

xmlrpc.php.diff Download (511 bytes) - added by josephscott 4 years ago.

Change History

Added patch makes zero and two do the same thing for mt_allow_comments.

  • Status changed from new to closed
  • Resolution set to fixed

(In [6347]) Correct support for mt_allow_comments to cover all possible values. Fixes #5366 props redsweater/josephscott

  • Milestone changed from 2.5 to 2.4
Note: See TracTickets for help on using tickets.