Ticket #5458 (closed defect (bug): fixed)
making get_pages and wp_list_pages faster
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 2.5 |
| Component: | Optimization | Version: | |
| Severity: | normal | Keywords: | has-patch needs-testing |
| Cc: |
Description
When there are a lot of pages, these functions slow down quite a bit. Should improve on the algorithm so that they speed up. (using logic similar to 5303).
Attachments
Change History
- Owner changed from anonymous to hailin
- Status changed from new to assigned
Per Ryan's request, I've rewrote the Walk class which is a core class used in wp_list_pages, etc to generate nested pages.
The resulting implemenation is much faster, with O(N) time complexity. and the code is more simple, thus easier to understand and maintain.
Tested on my local wporg and wpcom sandbox.
Working well in my tests. Now we can set hierarchical to false when calling get_pages() and get_terms() to avoid the hierarchy sorting done in those functions. Actually, get_terms() will require some finesse because it does some things to counts for term hierarchies.
Small patch that calls get_pages() with heirarchical set to 0 since the new walker code doesn't need get_pages() to pre-sort the results. Need to profile this with lots of pages.
comment:8
darkdragon — 4 years ago
- Component changed from General to Optimization
I think this should be moved to optimization, so I'm moving this to that category.

