Ticket #5458 (closed defect (bug): fixed)

Opened 4 years ago

Last modified 4 years ago

making get_pages and wp_list_pages faster

Reported by: hailin Owned by: ryan
Priority: normal Milestone: 2.5
Component: Optimization Version:
Severity: normal Keywords: has-patch needs-testing
Cc:

Description

When there are a lot of pages, these functions slow down quite a bit. Should improve on the algorithm so that they speed up. (using logic similar to 5303).

Attachments

5458_walk_core.diff Download (7.3 KB) - added by hailin 4 years ago.
patch
no_hier_pages.diff Download (426 bytes) - added by ryan 4 years ago.

Change History

  • Owner changed from anonymous to hailin
  • Status changed from new to assigned

Per Ryan's request, I've rewrote the Walk class which is a core class used in wp_list_pages, etc to generate nested pages.

The resulting implemenation is much faster, with O(N) time complexity. and the code is more simple, thus easier to understand and maintain.

Tested on my local wporg and wpcom sandbox.

hailin4 years ago

patch

comment:3   ryan4 years ago

Working well in my tests. Now we can set hierarchical to false when calling get_pages() and get_terms() to avoid the hierarchy sorting done in those functions. Actually, get_terms() will require some finesse because it does some things to counts for term hierarchies.

comment:4   ryan4 years ago

(In [6384]) Faster page and cat walker. Props hailin. see #5458

ryan4 years ago

comment:5   ryan4 years ago

Small patch that calls get_pages() with heirarchical set to 0 since the new walker code doesn't need get_pages() to pre-sort the results. Need to profile this with lots of pages.

  • Milestone changed from 2.5 to 2.4

comment:7   ryan4 years ago

(In [6399]) wp_list_pages() no longer requires get_pages() to do a hierarchical sort. Set hierarchical to false. see #5458

  • Component changed from General to Optimization

I think this should be moved to optimization, so I'm moving this to that category.

  • Keywords has-patch needs-testing added
  • Owner changed from hailin to ryan
  • Status changed from assigned to new
  • Status changed from new to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.