Suppress DB errors unless WP_DEBUG is true

[filosofo]

WordPress should assume that it's a production environment and not show DB errors.

Not sure how I feel about this. Spitting out error messages told a lot of people their plugins didn't work with 2.3 and is a useful thing for site owners. With them hidden, it'd go missed by most and they wouldn't know why something wasn't working.

Perhaps an alternate solution is to show them to administrator users regardless (manage_options ?), and only to everyone if WP_DEBUG is on.

Replying to Viper007Bond:

Perhaps an alternate solution is to show them to administrator users regardless (manage_options ?), and only to everyone if WP_DEBUG is on.

I think this might be a good idea, but it should probably be done at the WP_DEBUG level, if possible.

When doing hide/show pair, this patch restores the show state to what it was prior to hiding. This way we don't have to check WP_DEBUG everywhere.

Patch also does an error_log() inside print_error() so that the error info is always available in the error log.

+1

(In [6391]) Suppress display of DB error messages by default. Props filosofo. see #5473

(In [6443]) Suppress display of DB error messages by default. Props filosofo. fixes #5473 for 2.3

(In [6469]) Show DB errors if WP_DEBUG and if installing. see #5473

(In [6470]) Show DB errors if WP_DEBUG and if installing. see #5473