Ticket #5481 (closed defect (bug): fixed)

Opened 4 years ago

Last modified 4 years ago

Use is_numeric instead of ctype_digit in wp-admin/includes/image.php

Reported by: josephscott Owned by: anonymous
Priority: normal Milestone: 2.5
Component: Administration Version: 2.5
Severity: normal Keywords: has-patch
Cc: josephscott

Description

The use of ctype_digit() has brought in as part of r6309 in wp-admin/includes/image.php. This will sound odd, but I've run into PHP installs that don't have ctype_* functions available. Seems like the next best thing is to use is_numeric().

Attachments

image.php.diff Download (1.1 KB) - added by josephscott 4 years ago.

Change History

josephscott — 4 years ago

comment:1   josephscott — 4 years ago

use of the WordPress function absint() would be even better than is_numeric().

comment:2   ryan — 4 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [7549]) Use is_numeric instead of ctype_digit. Props josephscott. fixes #5481

Note: See TracTickets for help on using tickets.