id,summary,reporter,owner,description,type,status,priority,milestone,component,version,severity,resolution,keywords,cc
5553,add_rewrite_endpoint does not work for attachments,Curioso,westi,"The functionality for adding endpoints in rewrite rules does not work for attachments.
In wp-includes/rewrite.php:

{{{
                    //do endpoints for attachments
                    if ($endpoint) { foreach ($ep_query_append as $regex => $ep) {
                        if ($ep[0] & EP_ATTACHMENT) {
                            $rewrite[$sub1 . $regex] = $subquery . '?' . $ep[1] . $this->preg_index(2);
                            $rewrite[$sub2 . $regex] = $subquery . '?' . $ep[1] . $this->preg_index(2);
                        }
                    } }                                                                                              
}}}
should be:

{{{
                    //do endpoints for attachments
                    if ($endpoints) { foreach ($ep_query_append as $regex => $ep) {
                        if ($ep[0] & EP_ATTACHMENT) {
                            $rewrite[$sub1 . $regex] = $subquery . $ep[1] . $this->preg_index(2);
                            $rewrite[$sub2 . $regex] = $subquery . $ep[1] . $this->preg_index(2);
                        }
                    } }                                                                                              
}}}
Note the typing error in $endpoints, and the '?' is already present in $subquery.
",defect (bug),closed,normal,2.9,Permalinks,,normal,fixed,needs-patch needs-testing,