Context Navigation

← Previous Ticket
Next Ticket →

Ticket #5607 (closed defect (bug): fixed)

Opened 4 years ago

Last modified 4 years ago

Fix PHP Notices in admin

Reported by:	filosofo	Owned by:	westi
Priority:	normal	Milestone:	2.6
Component:	General	Version:	2.5
Severity:	normal	Keywords:
Cc:	filosofo

Description

Ah, the joys of having WP_DEBUG set to "true."

Attachments

remove_admin_notices.diff (2.1 KB) - added by filosofo 4 years ago.
remove_admin_notices2.diff (1.6 KB) - added by filosofo 4 years ago.
remove_admin_notices3.diff (2.2 KB) - added by filosofo 4 years ago.
remove_admin_notices4.diff (1.4 KB) - added by filosofo 4 years ago.
remove_admin_notices5.diff (4.2 KB) - added by filosofo 4 years ago.
remove_admin_notices6.diff (2.4 KB) - added by filosofo 4 years ago.
remove_admin_notices7.diff (4.0 KB) - added by filosofo 4 years ago.
remove_admin_notices8.diff (2.0 KB) - added by filosofo 4 years ago.
remove_admin_notices9.diff (2.6 KB) - added by filosofo 4 years ago.
remove_admin_notices10.diff (1.8 KB) - added by filosofo 4 years ago.
remove_admin_notices11.diff (4.7 KB) - added by filosofo 4 years ago.
remove_admin_notices12.diff (5.8 KB) - added by filosofo 4 years ago.
remove_admin_notices13.diff (2.2 KB) - added by filosofo 4 years ago.
remove_admin_notices14.diff (3.8 KB) - added by filosofo 4 years ago.
remove_admin_notices15.diff (1.7 KB) - added by filosofo 4 years ago.
remaining_notices.diff (29.8 KB) - added by westi 4 years ago.: Merged patch for wp-admin remaining notices

Change History

filosofo — 4 years ago

attachment remove_admin_notices.diff added

comment:1 westi — 4 years ago

Owner changed from anonymous to westi
Status changed from new to assigned

Thank you for the patch!

From a quick look through I am not sure that 100% of the changes are the best fix.

I will go through and review and commit soon.

filosofo — 4 years ago

attachment remove_admin_notices2.diff added

filosofo — 4 years ago

attachment remove_admin_notices3.diff added

filosofo — 4 years ago

attachment remove_admin_notices4.diff added

filosofo — 4 years ago

attachment remove_admin_notices5.diff added

filosofo — 4 years ago

attachment remove_admin_notices6.diff added

filosofo — 4 years ago

attachment remove_admin_notices7.diff added

filosofo — 4 years ago

attachment remove_admin_notices8.diff added

filosofo — 4 years ago

attachment remove_admin_notices9.diff added

filosofo — 4 years ago

attachment remove_admin_notices10.diff added

filosofo — 4 years ago

attachment remove_admin_notices11.diff added

filosofo — 4 years ago

attachment remove_admin_notices12.diff added

filosofo — 4 years ago

attachment remove_admin_notices13.diff added

filosofo — 4 years ago

attachment remove_admin_notices14.diff added

filosofo — 4 years ago

attachment remove_admin_notices15.diff added

comment:2 filosofo — 4 years ago

Sorry for so many patches, but I couldn't get a clean diff with a large patch.

What are some examples of problems with the changes?

comment:3 westi — 4 years ago

(In [6592]) Notice fixing for wp-includes. See #5607 props filosofo.

westi — 4 years ago

attachment remaining_notices.diff added

Merged patch for wp-admin remaining notices

comment:4 westi — 4 years ago

Ok wp-includes changes reviewed and some modifications made.

Patch for just the wp-admin changes uploaded - will review when I have some more time.

comment:5 jacobsantos — 4 years ago

Status changed from assigned to closed
Resolution set to fixed
Milestone changed from 2.9 to 2.6.1

I think there should only be one ticket for notices and warnings fixes per WordPress version. Closing as fixed. A new ticket should be created for 2.7, 2.8, etc.

comment:6 jacobsantos — 4 years ago

Keywords has-patch removed

comment:7 ryan — 4 years ago

Milestone changed from 2.6.1 to 2.6

Note: See TracTickets for help on using tickets.

Download in other formats: