Opened 5 years ago

Closed 5 years ago

#5652 closed enhancement (fixed)

Add extra parameters wp_list_bookmarks and wp_list_pages

Reported by: thee17 Owned by: ryan
Priority: normal Milestone: 2.7
Component: Template Version: 2.5
Severity: normal Keywords: has-patch
Cc:

Description

Add parameters to inside the hyperlink tags (named innerbefore and innerafter).

resolves: ​http://wordpress.org/support/topic/151364

Attachments (7)

add-innerbefore-innerafter.diff​ (667 bytes) - added by thee17 5 years ago.
Adds innerbefore and innerafter
pages.diff​ (2.9 KB) - added by thee17 5 years ago.
wp_list_pages patch
5652-link_-revision.diff​ (5.1 KB) - added by thee17 5 years ago.
New Patch for link_before and link_after
5652-link_-revision2.diff​ (3.3 KB) - added by thee17 5 years ago.
Another attempt
5652-2-7-revision.diff​ (5.1 KB) - added by thee17 5 years ago.
New version of revision that replaces the original errors of the last patch
5652 update for 2.7 trunk.diff​ (6.6 KB) - added by thee17 5 years ago.
As per Ryan an update to the current trunk.
5652 patch for 2.7 trunk fixed.diff​ (6.2 KB) - added by thee17 5 years ago.
Fixed and tested this time.

Download all attachments as: .zip

Change History (22)

thee17 — 5 years ago

Adds innerbefore and innerafter

comment:1   thee17 — 5 years ago

  • Version set to 2.5

comment:2   thee17 — 5 years ago

  • Keywords 2nd-opinion removed

comment:3   thee17 — 5 years ago

Created the Codex info for this patch if it gets commited.

​http://codex.wordpress.org/User:Thee17/2.5_Documentation

comment:4   ryan — 5 years ago

  • Owner changed from anonymous to ryan

comment:5   thee17 — 5 years ago

  • Summary changed from Add extra parameters wp_list_bookmarks to Add extra parameters wp_list_bookmarks and wp_list_pages

I know it hasn't been decided on what the terms will be but in this patch for wp_list_pages, i have used innerbefore and innerafter.

thee17 — 5 years ago

wp_list_pages patch

comment:6   ryan — 5 years ago

How about something like link_before and link_after? Also, make sure to set them to empty string in the defaults array.

comment:7   thee17 — 5 years ago

New Patch added:

  • $innerbefore is now $link_before.
  • $innerafter is now $link_after.
  • Defaults added as
  • Inline documentation changed in bookmark-template.php (post-template.php does not have documentation.

thee17 — 5 years ago

New Patch for link_before and link_after

thee17 — 5 years ago

Another attempt

comment:8   thee17 — 5 years ago

Revision 2 breaks WP

comment:9   thee17 — 5 years ago

  • Component changed from General to Template
  • Keywords template-added-options added

5652-link_-revision.diff has the final version of my recomended additions. I have tested it on a like site for the past several days and there hoes not seem to be an issue.

comment:10   thee17 — 5 years ago

  • Milestone changed from 2.5 to 2.6

I guess this is not going to happen in 2.5

comment:11   thee17 — 5 years ago

  • Keywords dev-feedback added; template-added-options removed

comment:12   thee17 — 5 years ago

  • Milestone changed from 2.6 to 2.7

thee17 — 5 years ago

New version of revision that replaces the original errors of the last patch

thee17 — 5 years ago

As per Ryan an update to the current trunk.

comment:13   ryan — 5 years ago 

PHP Parse error:  syntax error, unexpected T_ELSE in /Applications/MAMP/htdocs/trunk/wp-includes/post-template.php on line 455

Needs fix and testing.

thee17 — 5 years ago

Fixed and tested this time.

comment:14   thee17 — 5 years ago

  • Keywords dev-feedback removed

comment:15   ryan — 5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [9202]) link_before and link_after from thee17. fixes #5652

Note: See TracTickets for help on using tickets.