Ticket #5673 (closed defect (bug): fixed)

Opened 4 years ago

Last modified 4 years ago

Plugin activation error_scrape doesnt allways show errors

Reported by: DD32 Owned by: anonymous
Priority: normal Milestone: 2.5
Component: Administration Version: 2.5
Severity: normal Keywords: has-patch plugins
Cc:

Description

On some server setups where the Error reporting is set to None, or the display_errors php.ini directive is set to false, Fatal errors are not shown to the user on the plugins page after a failed activation.

Patch attached to enable both. (And ignore E_Notice errors)

Attachments

5673.diff Download (566 bytes) - added by DD32 4 years ago.
5673.2.diff Download (1.3 KB) - added by DD32 4 years ago.

Change History

DD32 — 4 years ago

comment:1 follow-up: ↓ 2   ryan — 4 years ago

source:trunk/wp-admin/plugins.php@6580#L46 needs to drop the display_errors check, right?

comment:2 in reply to: ↑ 1   DD32 — 4 years ago

Replying to ryan:

source:trunk/wp-admin/plugins.php@6580#L46 needs to drop the display_errors check, right?

Yep, You're right, I missed that line.

DD32 — 4 years ago

comment:3   DD32 — 4 years ago

Ticket requires #5658 to be fixed first. Else it redirects and claims that the last plugin on the list had the fault(And then doesnt display the scrape as the nonces dont match).

comment:4   ryan — 4 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [6627]) Always show plugin activation errors. Props DD32. fixes #5673

Note: See TracTickets for help on using tickets.