Opened 5 years ago
Closed 5 years ago
#5736 closed defect (bug) (fixed)
Merge profile.php and user-edit.php
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 2.5 |
| Component: | Administration | Version: | |
| Severity: | normal | Keywords: | |
| Cc: |
Description
Inspired by #5508, this patch tries to merge wp-admin/profile.php and wp-admin/user-edit.php, since these files contain much common code.
Some details:
- Both files are retained in order all old links to work. profile.php is almost empty and just sets a variable and loads user-edit.php
- Password strength meter and pluggable personal options are still available only on the profile page.
- The capability system was modified (with great help from Ryan) so that current_user_can('edit_user', $uid) returns true if the current user has id $uid
Attachments (1)
Change History (11)
nbachiyski — 5 years ago
comment:1
darkdragon — 5 years ago
comment:2
nbachiyski — 5 years ago
This one function is presentation-oriented and isn't used anywhere else, so it would better stay there.
- Resolution set to fixed
- Status changed from new to closed
comment:6
nbachiyski — 5 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
profile-update.php is no longer needed -- all the work is done in user-edit.php
with this patch the bug #5508 will be fixed? or its just a patch for merging the profile and user-edit php files?
Thanks
comment:10
westi — 5 years ago
- Resolution set to fixed
- Status changed from reopened to closed
Closing as fixed as I can't see anything left to do here.
Note: See
TracTickets for help on using
tickets.

That is a pretty sweet patch. I'll see about testing it over the weekend. If at all possible, can you move the function outside of the file into another file in the wp-admin/includes folder?
I think the goal is to have as much separate of presentation and business logic as possible. Just a suggestion, if you want to spend time doing it.