Ticket #5784 (closed defect (bug): fixed)

Opened 2 years ago

Last modified 2 years ago

List of Users on wp-admin/users.php has its headers skipped

Reported by: Potter_System Owned by: markjaquith
Priority: lowest Milestone: 2.5
Component: General Version: 2.5
Severity: trivial Keywords: trivial wp-admin has-patch
Cc: ffemtcj

Description

On wp-admin/users.php, the table used to list users had its headers skipped (in English, the ID header was over Username values, and so on)

Attachments

users_table_skipped.patch Download (0.7 KB) - added by Potter_System 2 years ago.
Editing values of th tags on users.php
5784.diff Download (1.7 KB) - added by markjaquith 2 years ago.
Another solution
5784.jpeg Download (26.5 KB) - added by ffemtcj 2 years ago.
Image showing incorrect alignment
r6778_user_administration.diff Download (1.3 KB) - added by ffemtcj 2 years ago.
Patch fixing alignment issue

Change History

Editing values of th tags on users.php

Another solution

  • owner changed from anonymous to markjaquith
  • status changed from new to assigned

I think it looks a little strange with the checkbox right next to the ID. It seems very different from similar interfaces I've seen where the checkboxes are clearly their own entity. See 5784.diff for a proposed solution.

I like the idea. The patch should use the "update" method to take advantage of automatic SQL escaping.

ffemtcj2 years ago

See  5779. The patch created in that ticket sets the formatting to the same as it is in the current version of WP. I don't see a need to change the formatting since there is nothing to gain from it. I suggest marking this as a duplicate.

ryan2 years ago
  • status changed from assigned to closed
  • resolution set to fixed

(In [6776]) Fix users table formatting. Props Potter_System and markjaquith. fixes #5784

ffemtcj2 years ago
  • cc ffemtcj added
  • status changed from closed to reopened
  • resolution fixed deleted

#5784 does still does not correctly align the user list (see attached image). Also attached is a patch that will fix the alignment issue.

ffemtcj2 years ago

Image showing incorrect alignment

ffemtcj2 years ago

Patch fixing alignment issue

ffemtcj2 years ago
  • status changed from reopened to closed
  • resolution set to fixed

Fixed r6852

Note: See TracTickets for help on using tickets.