Opened 5 years ago
Closed 4 years ago
#5802 closed defect (bug) (fixed)
Make RSS Default Consistent
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 2.9 |
| Component: | Feeds | Version: | 2.8 |
| Severity: | normal | Keywords: | has-patch |
| Cc: | filosofo |
Description
Currently get_default_feed() returns rss2 (RSS 2.0), but get_the_category_rss() has as default "rss--i.e. RSS 0.92--as the default.
Also, if you request "rss," either by /?feed=rss or /feed/rss/, the response is in RSS 0.92 format. To get RSS 2.0 you either have to request rss2 specifically or feed=feed.
Since RSS 2.0 is what you get from get_default_feed(), and because it's newer and has more features than RSS 0.92, it seems to me that default "rss" (?feed=rss or /feed/rss/) should be RSS 2.0, not 0.92 as it is now.
The attached patch:
- Makes "rss" RSS 2.0
- Lets you specify RSS 0.92 with rss092
- Makes the default value for get_the_category_rss() be whatever get_default_feed() returns
Attachments (2)
Change History (14)
- Component changed from General to Feeds
- Owner anonymous deleted
comment:2
peaceablewhale — 4 years ago
- Keywords dev-feedback added; RSS rss2 rss092 feed removed
- Milestone changed from 2.9 to 2.8
- Version set to 2.8
peaceablewhale — 4 years ago
comment:3
follow-up:
↓ 6
Denis-de-Bernardy — 4 years ago
- Keywords dev-feedback removed
shouldn't we change the default directly?
see also #10016
- Milestone changed from 2.8 to 2.9
punting per IRC discussion
comment:6
in reply to:
↑ 3
peaceablewhale — 4 years ago
Replying to Denis-de-Bernardy:
shouldn't we change the default directly?
Do you mean that you want to hard-code "rss2" to the functions?
yeah
comment:8
peaceablewhale — 4 years ago
However, the default feed format can be changed by admin using a plugin. I think the user's preferred format should be the default.
Was mostly asking for reference (both make sense to me).
patch still applies clean
see also #4595
comment:12
ryan — 4 years ago
- Resolution set to fixed
- Status changed from new to closed
I am going to attach a new patch that fixes get_the_category_rss and the_category_rss within next minute. However, I don't want to have rss092 as I really want to have it removed. Please refer to http://core.trac.wordpress.org/ticket/4967#comment:11 for details.