#5819 closed defect (bug) (fixed)
comments rss feed - namespace hook missing / feed invalid if link in comment-text
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | 2.8 |
| Component: | Feeds | Version: | 2.3.3 |
| Severity: | normal | Keywords: | has-patch tested commit |
| Cc: |
Description
hi folks!
during a customizing-session i noticed, that we miss the namespace-hook (i would suggest commentrss2_ns) in wp-includes/feed-rss2-comments.php.
moreover i checked my current feed with http://www.feedvalidator.org/ and found out that the comments-feed doesn't validate, if there is a link in a comment (perhaps of the no-follow attribute?). can anyone verify that behaviour?
berny
Attachments (3)
Change History (13)
the attached diff should solve the namespace-problem.
further, i opened a new ticket for the second issue http://trac.wordpress.org/ticket/6187 (valid comment feeds).
berny
- Component changed from General to Feeds
- Keywords tested commit added; feeds, rss, comment feeds removed
- Milestone changed from 2.9 to 2.8
- Owner anonymous deleted
- Resolution set to fixed
- Status changed from new to closed
comment:7
follow-up:
↓ 8
Denis-de-Bernardy — 4 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
@westi: in this case, we should also rename the one in the atom comments, for consistency.
- Resolution set to fixed
- Status changed from reopened to closed
Replying to Denis-de-Bernardy:
@westi: in this case, we should also rename the one in the atom comments, for consistency.
Please don't reopen tickets for different issues.
If you think this is worth changing raise a new ticket
will, do, but in the future, it would help if you wondered why I don't go for the obvious (which I agree is rss2_comments_ns in this case) in the first place. especially when I give the reason in the patch's comment: make the do_action consistent with what happens in atom.
see #9792

berny, thanks for participating in WordPress! One issue per ticket please.