Ticket #5855 (closed enhancement: fixed)

Opened 4 years ago

Last modified 4 years ago

Optimize generic_ping function

Reported by: fitztrev Owned by: anonymous
Priority: low Milestone: 2.5
Component: Optimization Version:
Severity: normal Keywords: has-patch
Cc:

Description

The generic_ping function currently sends weblog_ping() a null value if there is an empty line in the ping_sites option. The regexp pattern in the function only replaces 2 or more empty lines with 1--it doesn't get rid of it altogether. There's no check anywhere down the line to stop the IXR class from trying to ping an empty string.

This restructure will address this problem and speed the function up at the same time.

Attachments

generic-ping.diff Download (689 bytes) - added by fitztrev 4 years ago.
Don't ping empty strings.

Change History

Don't ping empty strings.

  • Keywords has-patch added

comment:2   ryan4 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [6853]) generic_ping() improvements from fitztrev. fixes #5855

Note: See TracTickets for help on using tickets.