Opened 5 years ago
Closed 5 years ago
#5868 closed defect (bug) (fixed)
Main navigation blue borders on the bottom of them and a blue border on the bottom of selected tabs
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | low | Milestone: | 2.5 |
| Component: | Administration | Version: | 2.5 |
| Severity: | normal | Keywords: | has-patch |
| Cc: |
Description
The main navigation tabs don't look completely right, with blue borders on the bottom of them and a blue border on the bottom of selected tabs. http://i243.photobucket.com/albums/ff32/hempsworth/tabs.jpg
Also, a strange bug in IE6 which causes a blue background/border on the current submenu item. http://i243.photobucket.com/albums/ff32/hempsworth/submenu.jpg
Both are fixed in the attached patch.
Attachments (8)
Change History (30)
hempsworth — 5 years ago
comment:1
hempsworth — 5 years ago
- Owner changed from anonymous to hempsworth
- Status changed from new to assigned
- Keywords has-patch added
- Milestone changed from 2.6 to 2.5
- Summary changed from Main navigation bugfix to Main navigation lue borders on the bottom of them and a blue border on the bottom of selected tabs
- Version set to 2.5
- Summary changed from Main navigation lue borders on the bottom of them and a blue border on the bottom of selected tabs to Main navigation blue borders on the bottom of them and a blue border on the bottom of selected tabs
comment:5
Speedboxer — 5 years ago
I thought that border was intentional... Looks good with it. It also further distinguishes a tab you're hovering over, and a selected tab.
comment:6
hempsworth — 5 years ago
The attached image shows the tabs before and after the patch is applied, with an active and hovered over tab; I think this was the intended effect in the first place.
- Resolution set to fixed
- Status changed from assigned to closed
comment:8
Speedboxer — 5 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
The patch creates a double-underline in both IE7 and FF2. It's fine in Safari (for Windows), though.
comment:9
follow-up:
↓ 10
hempsworth — 5 years ago
Hmm, are you sure you did a hard refresh etc.
I just downloaded a fresh copy of trunk and it's working fine for me in:
- FF2
- Safari 3 (Windows)
- IE7
- IE6
Could you post a screenshot if the problem persists, thanks!
comment:10
in reply to:
↑ 9
Speedboxer — 5 years ago
Replying to hempsworth:
Hmm, are you sure you did a hard refresh etc.
I just downloaded a fresh copy of trunk and it's working fine for me in:
- FF2
- Safari 3 (Windows)
- IE7
- IE6
Could you post a screenshot if the problem persists, thanks!
Yep, did a hard refresh, and reverted all modifications. I've attached a screenshot of what it looks like on the Dashboard (left) and what it looks like on the Write page with the mouse over Design (right). This is in IE7 on Vista, looks like same in FF2.
comment:11
ryan — 5 years ago
I had the double underline before, but the patch fixed it for FF2 and Safari on Mac. Go fig.
comment:12
Speedboxer — 5 years ago
Just checked it in IE6 on XP, same problem.
comment:13
Speedboxer — 5 years ago
Same problem in FF2 on XP and Opera on Vista.
comment:14
Speedboxer — 5 years ago
The latest patch fixes the double-underline. Just one more problem, the bottom of the hover box doesn't line up with the whole bottom border. If that makes sense.
comment:15
follow-up:
↓ 16
hempsworth — 5 years ago
Yep that makes sense :)
Try the revised version of double-underline-fix.patch
comment:16
in reply to:
↑ 15
Speedboxer — 5 years ago
Replying to hempsworth:
Yep that makes sense :)
Try the revised version of double-underline-fix.patch
I think either the whole border needs to be moved down a px, or the tabs need to be moved up a px...
comment:17
hempsworth — 5 years ago
The following patch is backtracking slightly and trying to fix:
the bottom of the hover box doesn't line up with the whole bottom border
...in a different way. Could you try this patch, and if it doesn't work, post a screenshot.
hempsworth — 5 years ago
comment:18
Speedboxer — 5 years ago
My patch fixes the problems. Except in Safari (for Windows) there's a small 1px gap between the bottom of the hover tab and the bottom border... I tested it in these browsers:
IE6 on XP
IE7 on Vista
Opera on Vista
FF2 on XP and Vista
Safari on Vista
comment:19
hempsworth — 5 years ago
Nice one, your patch works a treat!
comment:20
ryan — 5 years ago
comment:21
ryan — 5 years ago
comment:22
ryan — 5 years ago
- Resolution set to fixed
- Status changed from reopened to closed

Patch for both bugs