Media Library updates

[andy]

Target: bring the Media Library page into line with the Happy Cog mockup.

Patches: coming in bursts.

(In [6910]) Media Library design updates from Andy. see #5911

Fix the Delete button AYS

(In [6941]) Fix media delete nonce. Props andy. see #5911

file icons for wp-includes/images

(In [6974]) Media library work from andy. see #5911

update mime-to-icon matching

get filename from function instead of guid. fixes h-scroll caused by bad guid.

(In [7036]) update mime-to-icon matching and get filename from function instead of guid. Props andy. see #5911

incremental changes to bring behavior up to latest wireframes

(In [7043]) Media upload updates from andy. see #5911

fix overuse of default mime icon

re-shuffle mp4/m4a file type matches

(In [7045]) fix overuse of default mime icon and re-shuffle mp4/m4a file type matches. Props andy. see #5911

first pass at Media Library uploader tab

(In [7062]) Add media library uploader tab. Props andy. see #5911

remove debug cruft

set swfupload max file size to match php ini

(In [7067]) remove debug cruft and set swfupload max file size to match php ini. Props andy. see #5911

Button Revival!

(In [7092]) Media library updates from andy. see #5911

error improvements, localization, and icon improvements -- please do not commit before new icons arrive in wp-includes/images/crystal

(In [7100]) Media Library updates from andy. see #5911

Fix table styling

Revive and filter "Add media:" text beside upload buttons

(In [7151]) Table styling and "add media" label. See #5911. Hat tip: andy.

Improve upload_max_filesize error. Improve error display for long messages. New uploads now added to bottom, not top. Fix align class. Remove redundant header text.

(In [7160]) Improve upload_max_filesize error. Improve error display for long messages. New uploads now added to bottom, not top. Fix align class. Remove redundant header text. Props andy. see #5911

Fix insert, gallery, sizing, type queries, errors, thumbs, type fallback.

(In [7172]) Fix insert, gallery, sizing, type queries, errors, thumbs, type fallback. Props andy. see #5911

fix missing thumbnail radio button for inserting into post

(In [7177]) fix missing thumbnail radio button for inserting into post. Props andy. see #5911

Making a release blocker - we should close this when we are happy with the media library.

use new colors stylesheet

(In [7185]) Use the new colours stylesheet for the media library. See #5911 props andy.

fix icons

(In [7212]) Icon fixes. See #5911; hat tip: andy.

fix invisible delete links (now with media-upload iframe body id)

(In [7213]) Invisible ink delete links. See #5911. Also some old school colors, half-way done.

more thumbnail fixes

(In [7218]) More attachment thumbnail fixes, see #5911. Hat tip: andy.

remove ugliness from default attachment template

(In [7222]) Better media attachment template. See #5911. Hat tip: andy.

translate "Crunching..."

add Save button and fix tab+type breakage

(In [7228]) See #5911. Hat tip: andy.

"Deleted" message

(In [7256]) media handling fixes from andy. see #5911

use array(width, height) sizes in new image funcs

(In [7263]) Image fixes from andy. see #5911

I just noticed this, but patch 5911-14.diff in [7151] squishes the media icons (60px tall) into a max-height of 40px.

If it's necessary for image thumbnails, a class should be applied to thumbnails that gives them the max-height. Or, a class could be applied to file icons that gives them a height of 60px.

Now we have a funky media library that works a dream do we still need to keep wp-admin/includes/upload.php as it's not referenced by any WordPress code.

If so I guess we should make it as deprecated so we can remove it later.

I'm hoping this is the correct place for this. In my testing I've found a problem with the current Media Library. It seems to have been around for the last few revisions. I've compared two different test sites below that exhibit the same problem.

In the "Manage/MediaLibrary", when selecting any link in the "Media" column brings up the selected image's edit page as usual. At that point "Settings", "Plugins" and "Users" disappears from the top right of page and the following warning is displayed at the bottom of the page:

Warning*: Cannot modify header information - headers already sent by (output started at /home/longmead/public_html/just-thinkin/wp-admin/admin-header.php:26) in */home/longmead/public_html/just-thinkin/wp-includes/pluggable.php* on line *688

All plugins are deactivated during this test.

On my other test site currently running on r2998 the same thing occurs with the exception of slight change in the warning (different line #):

*Warning*: Cannot modify header information - headers already sent by (output started at /home/longmead/public_html/just-thinkin/wp25-test/wp-admin/admin-header.php:26) in */home/longmead/public_html/just-thinkin/wp25-test/wp-includes/pluggable.php* on line *687

Again, no plugins activated.

I'm to light yet on the ins and outs of the Wordpress code to troubleshoot this myself.

Correction to my last comment. In the first example, that site is running r7331.

Replying to KirkM:

Correction to my last comment. In the first example, that site is running trunk build r7331 and in the second example the trunk build is r7298.

This may be related to ticket #6206

last patch on this ticket: remove obviously unreachable code

(In [7347]) Remove old upload files. props andy. fixes #5911

As of r7355, upload.php is still linked from some pages in the admin area (i.e: Manage » Media Library)

I'm reopening the ticket in the hopes that either this file comes back or the link in edit.php is updated to whatever replaces upload.php

(In [7356]) Restore upload.php as we really need it. See #5911.

(In [7357]) Delete the correct upload.php. See #5911 props andy.

done

Showing bad effects of min-height: 40px; on the thumbnail/icon

It may have been overlooked, but I mentioned previously that the min-height of 40px needs to be adjusted as it's unnaturally squashing the media library icons. See  screenshot.

add rel attrs to attachment links inserted from uploader

pretty delete animation

fix squashed icons and use 80x60 thumbs

(In [7466]) pretty delete animation, fix squashed icons and use 80x60 thumbs, add rel attrs to attachment links inserted from uploader. Props andy. see #5911

For a brief few hours on Saturday, I was pleased to see a tags field added to the attachment editing page. It's gone now and I keep hoping it will come back. Can we get that back? Please?

A comment on a blog post of mine:

also if I go to manage => media library then below “appears with” => it says: “no title” I click on no title, assuming I could edit its title, and get this error:

You attempted to edit a post that doesn’t exist. Perhaps it was deleted?

the url changes to: http://pacura.ru/wordpress/wp-admin/post.php?action=edit&post=-1206700048

it seems the media library tries to edit a post?

I can reproduce it on the latest Trunk too.

Create a new draft, attach an image, make sure it saves, Head over to the Manage Media library, the post link on the Image "Appears with" directs to the Draft post ID, not the real post id.