Ticket #5915 (accepted defect (bug))

Opened 4 years ago

Last modified 2 years ago

Same problem as in #252: apop broken if zero occurs in banner in 2.3.3 class-pop3.php

Reported by: ASonno Owned by: westi
Priority: normal Milestone: Future Release
Component: Blog by Email Version: 2.3.3
Severity: normal Keywords: APOP Blogg by Email has-patch needs-testing
Cc:

Description

While extracting the banner (function parse_banner) in preparation for apop, the empty method is called on $digit which when zero returns false and hence doesn't get put into the resultant $banner.

Example parse_banner reply with <14649.123343777@…> but the string was "+OK ready <14649.1203343777@…>" or another example "+OK ready <14649.1203343777@…>" and $pop3->parse_banner give back <14419.12334323@…>

then a md5($AuthString) must fail, because the 0 is significant by apop.

I put a workaround at  http://www.babsi.de/silentapop/, that does it for me, but this touch also wp-main.php

Attachments

pop3.zerostrip.patch Download (582 bytes) - added by t.baboon 3 years ago.

Change History

comment:1   t.baboon — 3 years ago

  • Keywords has-patch needs-testing added

Here is a patch.

-- t.baboon

t.baboon — 3 years ago

comment:2   Denis-de-Bernardy — 3 years ago

  • Owner anonymous deleted
  • Component changed from General to Mail

comment:3   westi — 2 years ago

  • Owner set to westi
  • Status changed from new to accepted
  • Component changed from Mail to Blog by Email
  • Milestone changed from 2.9 to Future Release

Moving all blog-by-email bugs to a seperate component and out of 2.9.

This will all be address by a new canonical blog-by-email plugin which is under development and will hopefully be available by the time 2.9 is released.

Note: See TracTickets for help on using tickets.