Ticket #5973 (closed defect (bug): fixed)

Opened 4 years ago

Last modified 4 years ago

Admin should use semantic classes

Reported by: filosofo Owned by: iammattthomas
Priority: normal Milestone: 2.5
Component: Administration Version: 2.5
Severity: normal Keywords: css semantic-markup has-patch
Cc: filosofo

Description

As explained  here, semantic class names should reflect function, not a particular style. So for example "niceblue" isn't such a great class name, as a differently-styled admin page might not even use blue there.

WordPress advertises itself as a " semantic personal publishing platform", and there is at least one  ''A List Apart'' article supporting semantic class names (A List Apart is of course published by Happy Cog, the designers of the new WP admin theme), so this should be a part of the new WordPress design.

Attachments

remove_niceblue_class.diff Download (15.1 KB) - added by filosofo 4 years ago.
form-table.diff Download (15.1 KB) - added by iammattthomas 4 years ago.
Patches #5973 with .form-table class replacing .niceblue

Change History

Please let's fix this before the 2.5 release, as once it's out there, we plugin authors will be saddled with it for a long time. There's already someone  telling plugin authors to use "niceblue" in preparation for 2.5.

comment:2   ryan4 years ago

  • Owner changed from anonymous to iammattthomas

I pinged MT for some HC feedback. Changing it is a perl script away once a new name is decided upon.

comment:3   ryan4 years ago

Or, one patch -p0 away since you attached a diff. :-)

I agree completely; I'm going to suggest the name .form-table for the sake of specificity.

Patches #5973 with .form-table class replacing .niceblue

Perfect! Thanks.

comment:6   ryan4 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [7000]) Change niceblue class name to form-table. Props filosofo and mt. fixes #5973

Note: See TracTickets for help on using tickets.