Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#6121 closed defect (bug) (fixed)

RTL CSS in Login

Reported by: Ali_ix Owned by: anonymous
Priority: normal Milestone: 2.5
Component: Administration Version: 2.5
Severity: normal Keywords: rtl login css has-patch
Cc:

Description

Please include the 'login-rtl.css' file in login page after 'login.css' file.
And please remove the 'dir="rtl"' property on html tag there.

Attachments (1)

login-rtl-css.diff​ (562 bytes) - added by nbachiyski 5 years ago.

Download all attachments as: .zip

Change History (4)

nbachiyski — 5 years ago

comment:1   nbachiyski — 5 years ago

  • Keywords has-patch added
  • Milestone changed from 2.6 to 2.5

Attached is a patch, which loads login-rtl.css if we have the proper $text_direction.

Why shall we remove dir="rtl"?

comment:2   ryan — 5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [7203]) Include login rtl css. Props nbachiyski. fixes #6121

comment:3   Ali_ix — 5 years ago

Thanks for the fix.

Since we can handle the page direction in CSS, it would be unnecessary (dir="rtl"). By the way, it isn't an issue and it works.

Note: See TracTickets for help on using tickets.