Ticket #6213 (closed defect (bug): fixed)

Opened 4 years ago

Last modified 3 years ago

widget.php includes wrong javascript tag for category dropdown

Reported by: reppep Owned by:
Priority: normal Milestone: 2.8
Component: Widgets Version: 2.3.3
Severity: normal Keywords: validation
Cc:

Description

The Category dropdown uses JavaScript, and embeds it using the wrong (old?) syntax. Patch:

[root@inspector wp-includes]# diff -u widgets.php.ORIG widgets.php --- widgets.php.ORIG 2008-03-13 22:18:25.000000000 -0400 +++ widgets.php 2008-03-13 22:19:10.000000000 -0400 @@ -630,7 +630,7 @@

wp_dropdown_categories($cat_args . '&show_option_none= ' . ('Select Category'));

?>

-<script lang='javascript'><!-- +<script type="text/javascript"><!--

var dropdown = document.getElementById("cat"); function onCatChange() {

if ( dropdown.options[dropdown.selectedIndex].value > 0 ) {

Change History

I couldn't find the mistake that your describing in wp-includes/widgets.php with r7290.

Also, for future reference, please run a command like this:

svn diff > myPatchFile.diff

Then just attach that file. This way SVN handles it and it is much easier to read (when it is uploaded, we can view it using the Diff Viewer on Trac).

comment:2   ryan3 years ago

  • Owner anonymous deleted
  • Component changed from Template to Widgets
  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from 2.9 to 2.8

fixed in current trunk

Note: See TracTickets for help on using tickets.