Ticket #6387 (closed task (blessed): fixed)
Duplicate post Tags UI for other taxonomies
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | normal | Milestone: | 2.8 |
| Component: | General | Version: | |
| Severity: | normal | Keywords: | blessed |
| Cc: |
Description
This duplicates the Tags postbox UI (with the Add button and X to remove) for all non-hierarchical post taxonomies.
No doubt js experts will find it crude in spots but it works. I've left in two register_taxonomy() calls that I used for testing, lines 209 and 210 of edit-form-advanced.php. They're useful for testing this patch but should obviously be removed for production.
There's no real code for fetching or saving taxonomies other than post_tag. That should probably be included but requires some careful fitting with get_tags_to_edit() and friends so I've left it out for now. I added a quick filter as a crude fetch hook but it should probably be replaced with something more solid.
Attachments
Change History
comment:1
tellyworth — 4 years ago
The new patch has some better code for saving and fetching. Note that, while wp_insert_post() still supports the tags_input item for compatibility, the new UI code now passes in $_POSTtax_input? instead.
The temporary test taxonomies are still there but moved to the bottom of taxonomy.php.
tellyworth — 4 years ago
-
attachment
post-taxonomy-ui-r7521-3.patch
added
fix conflicts and diff against 7521
tellyworth — 4 years ago
-
attachment
post-taxonomy-ui-r7521-4.patch
added
fix css, l10n, autosave, enter keypress
Would love if the get and set of post terms dealt with IDs instead of names since we're in the code.
tellyworth — 4 years ago
-
attachment
post-taxonomy-ui-r7641-6.patch
added
Updated patch applies to trunk
comment:4
tellyworth — 4 years ago
Same patch as before, but applies cleanly to r7641.
tellyworth — 4 years ago
-
attachment
post-taxonomy-ui-r8339-2.patch
added
patch against r8339 plus improvements
- Milestone changed from 2.7 to 2.8
Feature freeze.. move to 2.8 for now.
-
attachment
taxonomies-ui.r10210.patch
added
post taxonomies ui patched against r10210
Instead of passing a taxonomy arg to a tag function, we should just use the generic term function. That tag functions are convenience wrappers but if we're passing a taxonomy to them they are fairly pointless.
comment:10
ryan — 3 years ago
Not sure what the show_message() call is about. Seems it should be removed.
-
attachment
6387-r10221.diff
added
Lose show_message(). Fix notices. Use generic terms funcs instead of passing tax to tag funcs.
