WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#6436 closed defect (bug) (fixed)

Shortcode attributes passing incorrectly

Reported by: stevish Owned by: anonymous
Priority: highest omg bbq Milestone: 2.5
Component: General Version: 2.5
Severity: blocker Keywords: has-patch
Cc:

Description

In WP2.5 RC3, when adding attributes to a shortcode (such as [gallery columns="3"]) any quotation marks are passed as part of the variable. Therefore, in this example, the $columns variable would contain ”3″ instead of just 3. The same happens when using single quotes.

As far as I can tell, there is no way to use values with spaces, as everything after the space is ignored.

Attachments (1)

6436.diff​ (332 bytes) - added by andy 5 years ago.
filter shortcodes before wptexturize

Download all attachments as: .zip

Change History (5)

comment:1 matt — 5 years ago

  • Priority changed from high to highest omg bbq
  • Severity changed from major to blocker

andy — 5 years ago

filter shortcodes before wptexturize

comment:2 andy — 5 years ago

  • Keywords has-patch added; RC3 removed

comment:3 matt — 5 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [7561]) Shortcode quotes were getting texturized, which can cause a bit of chaos. Fixes #6436.

comment:4 markjaquith — 5 years ago

See #6444 -- this changeset causes really funky HTML. wpautop() mangles the heck out of gallery code, and likely will mangle other code.

Note: See TracTickets for help on using tickets.