Ticket #6443 (closed defect (bug): fixed)

Opened 4 years ago

Last modified 4 years ago

flash uploader didn't show in IE7, showed script errors

Reported by: tsimmons Owned by: anonymous
Priority: high Milestone: 2.5.1
Component: Administration Version: 2.5
Severity: critical Keywords: has-patch commit
Cc:

Description

When opening the "Add Media" dialog, the flash uploader was absent and instead replaced with the standard "file" input. The reason was due to two script errors that IE didn't like.

Deleting two extra commas in two files fixes the issue. I'm attaching a proposed patch.

Attachments

fileuploaderfix.patch Download (1.3 KB) - added by tsimmons 4 years ago.
diff for patch

Change History

tsimmons — 4 years ago

diff for patch

comment:1   Viper007Bond — 4 years ago

  • Keywords has-patch commit added
  • Priority changed from normal to high
  • Severity changed from normal to blocker

This is one of those bugs that drives me absolutely nuts.

comment:2   thee17 — 4 years ago

I too have tried this, and it works for me in IE7 on XP, also tested doesnt break Safari 3 Mac, FF2 Mac, FF2 XP.

comment:3   lloydbudd — 4 years ago

  • Severity changed from blocker to critical
  • Milestone changed from 2.6 to 2.5.1

comment:4   markjaquith — 4 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [7572]) Remove errant commas to prevent file uploader script errors in IE7. props tsimmons. fixes #6443 for trunk

comment:5   markjaquith — 4 years ago

(In [7573]) Remove errant commas to prevent file uploader script errors in IE7. props tsimmons. fixes #6443 for 2.5.1

Note: See TracTickets for help on using tickets.