Context Navigation

← Previous Ticket
Next Ticket →

Ticket #6489 (closed defect (bug): fixed)

Opened 4 years ago

Last modified 3 years ago

Revisions do not respect time zone offset

Reported by:	sillybean	Owned by:	anonymous
Priority:	high	Milestone:	2.7.1
Component:	Revisions	Version:	2.5
Severity:	major	Keywords:	autosave revision timezone offset has-patch dev-feedback needs-testing
Cc:	janbrasna

Description

The timestamp on the autosave message doesn't include the time zone offset. The reported time is therefore confusing.

Attachments

post-template.php.diff (697 bytes) - added by janbrasna 3 years ago.
admin-ajax.php.diff (546 bytes) - added by janbrasna 3 years ago.
6489-admin-ajax.php-post-template.php.diff (1.2 KB) - added by janbrasna 3 years ago.: Fixes #6489, obsoletes previous patches.

Change History

comment:1 sillybean — 4 years ago

Summary changed from Autosave does not respect time zone offset to sorry, forgot not to set that milestone!
Milestone 2.5.1 deleted

comment:2 sillybean — 4 years ago

Summary changed from sorry, forgot not to set that milestone! to Autosave does not respect time zone offset

comment:3 Viper007Bond — 4 years ago

Yeah, I had this occur to me the other day and confused the hell outta me.

comment:4 lloydbudd — 4 years ago

Milestone set to 2.6

comment:5 Viper007Bond — 4 years ago

Also see this dupe: #6563

comment:6 janbrasna — 3 years ago

Keywords revision timezone offset added
Priority changed from low to high
Summary changed from Autosave does not respect time zone offset to Revisions do not respect time zone if offset differs between settings and server
Severity changed from minor to major
Milestone changed from 2.9 to 2.7

It's not only autosave, the whole revision system uses server time zone for display.

I think that the severity is rather high, because it leads to using wrong versions or total confusion.

Basically it's borked at the point when the datetime of a revision is retrieved via GMT since it's then converted via date_i18n to TZ of the server. Additionally any TZ info of the original revision is lost (imagine you change TZ for daylight savings and then the math via GMT fails to show the original time the revision was saved.) There's AFAIK no reason not to use the actual date with offset info from the DB for displaying it.

Attaching patch, please review.

janbrasna — 3 years ago

attachment post-template.php.diff added

comment:7 janbrasna — 3 years ago

The same TZ issue is in the inline flash, see another patch.

janbrasna — 3 years ago

attachment admin-ajax.php.diff added

comment:8 janbrasna — 3 years ago

Keywords has-patch added

comment:9 janbrasna — 3 years ago

Keywords dev-feedback added
Summary changed from Revisions do not respect time zone if offset differs between settings and server to Revisions do not respect time zone offset

comment:10 janbrasna — 3 years ago

Cc janbrasna added

comment:11 janbrasna — 3 years ago

Keywords needs-testing added

Also see this dupe: #8307

comment:12 markjaquith — 3 years ago

Status changed from new to closed
Resolution set to worksforme
Milestone 2.7 deleted

Works for me... I'm seeing my offset correctly reflected. Reopen if still an issue in WP 2.7 final

comment:13 janbrasna — 3 years ago

Status changed from closed to reopened
Resolution worksforme deleted
Milestone set to 2.7

The bug is still present as of 2.7-RC1-10151 and 2.7-RC2.

Please make sure when tagging as worksforme that you have the same conditions/setup. This bug only occurs when user's local and server time zones differ, see comment:6 ...

I'm attaching a new combined patch which is quite self–explanatory and tested with various time zone combinations, I'd just appreciate some dev-feedback, otherwise it could be checked in.