Gallery shortcode produces invalid XHTML, in all cases

[asiah]

Note: I use Firefox 2.0.0.13 and the Web Developer Plugin's validation tools.

I made note of this at the WP-Testers mailing list, but as of a few minutes ago, no one has responded to my comment. The silence has revealed to me two things.

The Dashboard no longer validates according to XHTML standards. It's petty, but it might solve some of the other issues that have cropped up by correcting it.

Inserting individual images into a post is flawless, posing no threat to validation, whereas inserting a gallery reveals issues with missing alt attributes, unclosed br tags, and misplaced style elements (<style type='text/css'>...).

I hope this issue can be addressed soon as I've been awaiting the arrival of the Gallery feature for quite some time. If not, how can I fix this at a local level, perhaps in some WP system file? Thanks so much for your assistance.

If you require a hands on look, check out the following post.  http://www.evitae.net/archives/2008/03/31/wordpress-25/

Duplicate of #6461 and #6496.

Replying to ionfish:

Duplicate of #6461 and #6496.

Thanks for the speedy update. I was able to make all of these work, except one extraneous <p> tag continued to remain until I surrounded the [gallery] shortcode with a meaningless empty <div> as follows: <div>[gallery]</div>

This fix may not be as apparent to others, and I am concerned that perhaps I might have overlooked something that might have addressed this issue. I doubt it, as I've completed the process a dozen times, comparing files and all. If anyone could be so kind as to point me in the right direction, I would be most appreciative.

markjaquith is dealing with this in a wpautop() ticket: #6444.

This never got dealt with in #6444, the gallery is *still* producing invalid XHTML, everywhere it's being used.

STYLE tags are not allowed in the main BODY. They can only be in the HEAD.

Are there any plans to fix this? The gallery is basically unusable because of this sort of thing.

Replying to Otto42:

This never got dealt with in #6444, the gallery is *still* producing invalid XHTML, everywhere it's being used.

STYLE tags are not allowed in the main BODY. They can only be in the HEAD.

Are there any plans to fix this? The gallery is basically unusable because of this sort of thing.

Agreed, this is a bug that has to be fixed.

This problem is mentioned in #6618, #6380, and #6927, but it needs a separate report of it's own. There is a patch attached to #6380 that purports to fix this, but it is an ugly solution and that patch won't apply to the current code base. That report also doesn't explicitly address this issue.

Any ideas? This is still a serious problem as it's producing invalid code. I've looked at it, but I'm not sure what the correct solution is.

I think we should simply rip the style out of the gallery code and put it in the theme's CSS, where it belongs.

My muli-gallery support ticket #7607 has XHTML 1.0 fix for the shortcode if it needs to be used. It puts the Gallery code inside the .css files.