Recursively search for files in theme and plugin editors

[torbens]

Themes (like Subtle: ​http://gluedideas.com/downloads/subtle/) might contain numerous CSS files. The theme editor, however, does not recognize any other CSS files other than style.css.

The files might be located some levels deeper in sub directories like '/wp-content/themes/glued-ideas-subtle-01/assets/css/print.css'.

Could be lumped in with #6632 maybe. No point in having 2 generic editors. Not sure how common buried stylesheets are.

See also #4131. This is possibly a dupe.

It's not common, but it occurs. The patch from #6632 partially sorts this if the files are in a direct subfolder. If you've a file any deeper, it won't do any good. example:

wp-content/themes/sem-reloaded/skins/copywriter-blue/skin.css

the same may also apply to plugins.

Patch is attached.

It includes :

• recursive search for files in both Theme and Plugin editors
• sorting of files by path and name
• inclusion of JavaScript files in the Theme editor

It seem it will already recursively search for PHP files.

Is there any logical reason why you would not display all of the theme's CSS files from subdirectories in the theme editor?

Changing to a bug because expected behaviour is that all CSS files in the theme are shown.

The patch i've submitted two months ago brings this fonctionnality for CSS, JS and PHP files.

Is there any reason why you would NOT want to apply this patch?

Is there any reason you would NOT want this feature?

This bug has been open for 4 years, is there any reason why this bug cannot be closed?

Thanks!

I would like to see this on future release. Perhaps the directory structure with js/jq implement.

Related: #17036

#23500 was marked as a duplicate.

Related: #22924

#24050 was marked as a duplicate.

patch from 24050 that was a duplicate of this ticket.

Thanks Mike for the patch! Verified, works. Also improves the coding style to match ​http://make.wordpress.org/core/handbook/coding-standards/php/.

I'd like to see this included in 3.6 after two improvements:

1. Use curly braces with all ifs. Avoids hassle and bugs in later edits. A decent percentage of bugs are caused by editing code like this:

} else {
	if ( plugin_basename("$dir/$file") != $plugin )
		$plugin_files[] = plugin_basename("$dir/$file");
}

2. Theme editor could use the same functionality.

Marking ticket as defect (bug) instead of enhancement. More appropriate for the file list not displaying all files of a plugin or theme. Milestone, anyone?

3. In order to improve performance, instead of calling this function twice inside a loop:

   plugin_basename("$dir/$file")
   

Split it into these parts, the first of which is to be called only once in the beginning of the function:

$plugin_basedir = plugin_basename($dir);
...
"$plugin_basedir/$file"

The patch in #24049 also applies this change.

Encountered a bug:

4. After opening a file from within a subdirectory, the Plugin Files lists only files and directories under that subdirectory.

should fix the bug mentioned in comment 19

Turns out the bug in comment 19 affects core now. Should it be a separate ticket, even though 24050.2.diff fixes it? Also I still think there needs to be some ui improvements for the long list.