404 page does not appear when using static home page

[natecook]

If an installation is configured to have the home page set to a static page, with the "Front page" set but the "Posts page" unset, instead of the 404 template showing up when necessary, all pages are loaded and displayed.

Patch for fix

On r7591 I'm not seeing a error, if I enter garbage in the browser's navigation bar I get the 404 page as expected. Is there anything in particular that it should be doing?

I encountered this after upgrading from 2.3.3, and reproduced it on a clean 2.5 installation. The patch corrected the issue.

I'm not sure whether it's cool for a non-developer to change milestones, but here goes.

Usually we milestone for the current development version (or the next one if no patch is attached) and once it's comitted and deemed important enough it will be backported for a maintenance release.

(In [7605]) Explicit ID check so we don't fall through for empties. Props natecook. fixes #6539 for 2.6

(In [7606]) Explicit ID check so we don't fall through for empties. Props natecook. fixes #6539 for 2.5

This is one looked safe for 2.5.1, committed.

(In [7622]) Revert [7605]. It breaks setting posts page. see #6539

(In [7623]) Revert [7606]. It breaks setting posts page. see #6539

The patch typecasts $reqpage to integer temporarily only when 404. This way it won't break setting posts page.

The patch typecasts $reqpage to integer temporarily only when 404. This way it won't break setting posts page.

The patch typecasts $reqpage to string.

I updated 6539.patch. It does almost the same thing, but less code.

Patch for 2.5 branch. Typecasts $reqpage to string to make the conditional work properly.

Patch 6539.patch didn't work for me. Merged the additional equal sign fix from the query-404.diff patch and tested working on WordPress 2.5.1.

(In [7905]) Fix page 404 when page_for_posts is empty. see #6539

(In [8099]) Fix page 404 when page_for_posts is empty. fixes #6539

Milestone 2.5.2 deleted