Ticket #6544 (closed defect (bug): fixed)

Opened 4 years ago

Last modified 4 years ago

TinyMCE HTTPS handling

Reported by: blenjee Owned by: azaozz
Priority: normal Milestone: 2.5.1
Component: TinyMCE Version: 2.5
Severity: normal Keywords: tinymce, https has-patch
Cc:

Description

In /wp-includes/js/tiny_mce/tiny_mce_config.php, line 52 should read:

if ( $https ) $baseurl = str_replace(' http://', ' https://', $baseurl);

and line 56 should read:

if ( $https ) $mce_css = str_replace(' http://', ' https://', $mce_css);

At present (2.5) the replaced string is not being assigned, so when using HTTPS (with, for example, the admin-ssl plugin) the TinyMCE CSS files are being called using HTTP.

Attachments

6544.diff Download (898 bytes) - added by Nazgul 4 years ago.
6544.2.diff Download (1.0 KB) - added by azaozz 4 years ago.
Includes the above patch plus one more place that needed fixing.

Change History

  • Severity changed from normal to blocker
  • Keywords has-patch added
  • Severity changed from blocker to normal
  • Milestone set to 2.6

Patch attached, based on the given code snippets.

Also a candidate for 2.5.1.

Nazgul4 years ago

  • Owner changed from anonymous to azaozz

azaozz4 years ago

Includes the above patch plus one more place that needed fixing.

  • Milestone changed from 2.6 to 2.5.1

comment:5   matt4 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [7602]) Allow TinyMCE to work under SSL. Fixes #6544. Hat tip: blenjee, azaozz.

  • Milestone changed from 2.5.1 to 2.6

It was fixed in trunk.

Maybe backport it to 2.5.1?

  • Status changed from closed to reopened
  • Resolution fixed deleted
  • Milestone changed from 2.6 to 2.5.1

Yes - please backport to 2.5.1. My company requires the use of HTTPS for sites requiring login, so this a maintenance hassle for me as the admin :-/

(not sure if I'm breaking protocol by changing the milestone and re-opening - if so, my apologies!)

Thanks!

comment:8   ryan4 years ago

  • Status changed from reopened to closed
  • Resolution set to fixed

(In [7675]) Allow TinyMCE to work under SSL. Fixes #6544 for 2.5. Hat tip: blenjee, azaozz.

Note: See TracTickets for help on using tickets.