File upload limit - error message

[simonwheatley]

To reproduce:

1. In php.ini, set post_max_size to something very low (e.g. 1K)

2. Restart Apache

3. Create a new post, and upload a file of over 1Kb.

4. The error message makes mention of upload_max_filesize, but not post_max_size.

The attached patch amends the error message to mention both php.ini values (post_max_size & upload_max_filesize).

There are implications for localisation with this patch, in that it changes a localised string.

Amends upload filesize error to mention all relevant php.ini values

Ooops, uploaded the wrong patch. See other.

Examples of this confusing people:
​http://wordpress.org/support/topic/165353

Milestone 2.5.2 deleted

can't get the patch to apply

I'm pretty sure this was fixed by DD32's patch related to the file upload error messages a few months back.

Yes, it was addressed in #10495. But the committed changes make no explicit mention of "php.ini" or either setting. Should it?

But the committed changes make no explicit mention of "php.ini" or either setting. Should it?

In my opinion, No. there are 2 sets of people who'll encounter this issue:

• Shared hosting users - They have to contact their host regardless.
• Dedicated setups
  • End user using it - Server configuration, contact the sys admin
  • Sys admin - Should understand that they need to edit their php.ini file

What i'm saying, Is that, In my opinion, its not worth confusing some users who cant find their php.ini file as they dont have access to it, and instead just refer to it as a server config error.. If a Sys admin comes accross it, They should already know they need to setup PHP correctly.

..And if all else fails, Googling the error will bring up a least 1 support forum thread on it at some point.

Makes sense to me, I completely agree. Just wanted to cross-reference the older ticket and confirm the behavior.

Related: #13575