Ticket #6806 (closed defect (bug): fixed)

Opened 4 years ago

Last modified 4 years ago

image_send_to_editor is called twice for every image

Reported by: AaronCampbell Owned by: anonymous
Priority: high Milestone: 2.6
Component: General Version:
Severity: major Keywords: has-patch needs-testing
Cc:

Description

Inside the get_image_send_to_editor function in wp-admin/includes/media.php, first get_image_tag is called, which applies the filter image_send_to_editor, then later in that same function the image_send_to_editor filter is applied again. I'm adding image captioning, so I need to modify the image code sent to the editor, but not the image tag. We should change the call inside get_image_tag to be "get_image_tag" rather than "image_send_to_editor"

Patch Attached.

Attachments

6806.001.diff Download (674 bytes) - added by AaronCampbell 4 years ago.

Change History

comment:1   ryan4 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [7838]) Don't reuse image_send_to_editor filter in get_image_tag(). Props AaronCampbell. fixes #6806 for trunk

comment:2   ryan4 years ago

(In [7839]) Don't reuse image_send_to_editor filter in get_image_tag(). Props AaronCampbell. fixes #6806 for 2.5

comment:3   ryan4 years ago

  • Milestone changed from 2.5.2 to 2.9

Milestone 2.5.2 deleted

  • Milestone changed from 2.9 to 2.6
Note: See TracTickets for help on using tickets.