wp_list_pages() should also lists private pages if the user has capability 'read_private_pages'

[imwebgefunden]

If the user has the capability "read_private_pages" wp_list_pages() don't lists private pages in no way. I've noticed this problem by some comments on my "Role Manager" Plugin page.

Two patches are attached to this ticket.

wp_list_pages() gets a new option "include_private_pages". The default value is 1 for lists private pages too if the user has the capability "read_private_pages".
If private pages should not be listed also if the user has the cap "read_private_pages" the syntax is as an example:
wp_list_pages('title_li=<h2>Pages</h2>&include_private_pages=0');

The second patch is for get_pages() - with the same option and default value.

And of course: if a user don't has the cap "read_private_pages" private pages are listed in no case :)

Patch for wp-includes/post-template.php

Patch for wp-includes/post.php

This is a very useful patch!
I think it should be included in Wordpress.
Works like a charm for me.

Milestone 2.5.2 deleted

Don't know if this help, but I can confirm that this bug is still present in WordPress 2.6.

I agree that this is a very useful patch and should be included in the next release. That is the one thing I have to change in the core after each update, although I use:

... WHERE (post_type = 'page' AND " . get_private_posts_cap_sql('page') . ") ...

The get_private_posts_cap_sql function does basically the same as in the patch here, but is already included in Wordpress and additionally lists the user's own private pages, even if they have no permission to read private posts.

suggesting wontfix, personally. private pages don't belong in that menu. or then:

• we should at least add an option to show them, off by default, for performance reasons
• we may gain advantage to grab all pages, private or not, and use the walker to remove the private ones

Respectfully disagreeing; private pages absolutely do belong in this menu. Where else would they go? Most sites have a single navigation menu. It makes sense to include the private pages there when needed rather than requiring a separate menu for them.

See also #8592

The patches on #8592 should resolve this problem and #4711.