Opened 5 years ago

Last modified 2 years ago

#7051 new enhancement

Delete blacklisted comments rather than mark them as spam

Reported by: donncha Owned by:
Priority: normal Milestone: Future Release
Component: Comments Version: 2.5.1
Severity: normal Keywords: has-patch
Cc:

Description

Comments that are blacklisted because of the Blacklist keys on options-discussion.php should be deleted immediately instead of being marked as spam. Patch attached.

Attachments (2)

comment.diff (1.1 KB) - added by donncha 5 years ago.
Patch for wp-includes/comment.php
7051.diff (1.6 KB) - added by solarissmoke 2 years ago.
Place blacklisted comments in the trash

Download all attachments as: .zip

Change History (13)

donncha5 years ago

Patch for wp-includes/comment.php

This seems like a pretty big change. Can you say why blacklist matching comments should be deleted?

I have "casino" in my blacklist, but if I ever write a post about going to Vegas, I don't want all the comments to get deleted.

Yeah, I think spam is best. Allows for recovery.

This is something Photomatt and Markr wanted. Markr brought it up in conversation with a blogger who is getting lots of stupid comments from one particular user. He added that person's email address or IP into the blacklist expecting the comments to be deleted but instead he had to read the comments in the Akismet spam page and delete them.

They weren't submitted to Akismet so the spam page is probably the wrong page for these comments to be left in.

This is a result of confusion over what the blacklist does. Is it a spam list or stupid list? :)

Perhaps a new status is in order or something.

It just seems like not having them be instantly deleted would be a good idea incase there was a false positive as mdawaffe mentioned (Vegas).

comment:5   ryan5 years ago

  • Milestone changed from 2.5.2 to 2.9

Milestone 2.5.2 deleted

  • Component changed from General to Comments
  • Owner anonymous deleted
  • Keywords needs-patch close added; has-patch removed
  • Milestone changed from 2.9 to Future Release
  • Type changed from defect (bug) to enhancement

suggesting wontfix, personally.

  • Keywords needs-patch removed

comment:9 follow-up: ↓ 10   nacin2 years ago

Perhaps now that we have Trash, that could be where they end up?

comment:10 in reply to: ↑ 9   Viper007Bond2 years ago

Replying to nacin:

Perhaps now that we have Trash, that could be where they end up?

Strong +1

Allows recovery still and is a better fit. The comments from people on the blacklist aren't necessarily spam, they're just unwanted comments.

Place blacklisted comments in the trash

  • Keywords has-patch added; close removed
Note: See TracTickets for help on using tickets.