Opened 5 years ago

Last modified 4 years ago

#7244 new enhancement

Disable POP auth when APOP fail

Reported by: lilyfan Owned by:
Priority: normal Milestone: Future Release
Component: Mail Version: 2.3
Severity: normal Keywords: has-patch needs-testing reporter-feedback
Cc:

Description

If APOP authentication is failed, class-pop3.php tries normal POP auth (USER/PASS).
When a server only accepts APOP authentication, the second process should be fail for sure.
It is nonsence and harmful, because the error message of first process (APOP) is over-written by second try (POP).

To solve the desmiss of APOP fail message, it is neccesary to disable normal POP authentication.
I propose a new class variable $ALLOWLOGIN to decide it.

Additonaly, $ALLOWAPOP is useless because it is no problem to fix it TRUE. (Removing this variable is not included in the patch)

Attachments (2)

pop3.patch (527 bytes) - added by lilyfan 5 years ago.
Patch for wp-includes/class-pop3.php
7244.diff (1.9 KB) - added by Denis-de-Bernardy 4 years ago.
trac-readable version of lilyfan's 7244.patch

Download all attachments as: .zip

Change History (12)

lilyfan5 years ago

Patch for wp-includes/class-pop3.php

  • Milestone changed from 2.9 to 2.7

comment:2   ryan5 years ago

  • Milestone changed from 2.7 to 2.8

Moving enhancements to 2.8.

  • Component changed from General to Mail
  • Owner anonymous deleted

might be worth pushing this upstream

trac-readable version of lilyfan's 7244.patch

  • Keywords commit added

commit, wontfix?

  • Keywords needs-testing reporter-feedback added; commit removed

mmm... @lilyfan: why change?

if( (!$count) || ($count == -1) )
  • Milestone changed from 2.8 to 2.9

Moving to 2.9 as we are in beta now and I don't want to risk changes in this area at this time.

punting pending reporter feedback

  • Milestone changed from 2.9 to Future Release
Note: See TracTickets for help on using tickets.