Opened 5 years ago
Closed 5 years ago
#7550 closed enhancement (fixed)
Inline documentation corrections for 2.7
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Priority: | low | Milestone: | 2.7 |
| Component: | General | Version: | |
| Severity: | trivial | Keywords: | phpdoc has-patch commit close-2.7 |
| Cc: |
Description
The inevitable inline documentation correction ticket for WordPress 2.7. Also inevitable that no one else will find this ticket, when they find corrections, but meh.
Attachments (17)
Change History (48)
attachment 7550.r8674.diff added.
Corrections for TinyMCE Spellchecker plugin for adding @package phpdoc tags, based off of r8674
The patch has been sent upstream to the Moxiecode Sourceforge patch tracker. It is unknown when or if they are going to apply the patch. Including here to fix inclusion of some TinyMCE Spellchecker plugin classes into the WordPress phpdocumentor namespace.
Subpackage corrections to include install helper functions into the "Plugin" namespace, based off of r8674
attachment 7550.r8674.install-helper.diff added.
Patch added to apply the installer helper functions to the "Plugin" namespace, instead of the current "Plugins" namespace. It would make more sense to have it that way instead of the current way since Plugins are going to wait to use it and the "Plugin" namespace already exists.
- Owner changed from anonymous to westi
- Status changed from new to assigned
comment:6
jacobsantos — 5 years ago
#7243 includes @since version corrections, which I do have a patch for, but haven't uploaded. I'm probably going to correct the short descriptions along with the patch in one go. Might as well create a patch for all of the corrections I have so far.
jacobsantos — 5 years ago
Corrections to since and short descriptions, among other based off of r8687
comment:10
jacobsantos — 5 years ago
I have one more file: kses.php that I have corrections for before this ticket is complete. Probably reopen if there any more after that.
comment:11
jacobsantos — 5 years ago
- Keywords has-patch commit added
Final corrections for WordPress 2.7, corrects KSES.php file.
comment:12
westi — 5 years ago
- Resolution set to fixed
- Status changed from assigned to closed
comment:13
jacobsantos — 5 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Have patch for http.php to correct inline documentation in that file as well.
comment:14
azaozz — 5 years ago
- Resolution set to fixed
- Status changed from reopened to closed
comment:15
jacobsantos — 5 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Patch includes more fixes for two files.
comment:16
azaozz — 5 years ago
comment:17
jacobsantos — 5 years ago
I'm not sure, leave this open for the rest of the inevitable corrections to late night ramblings and day time incoherency or keep reopening and closing until 2.7 roadmap is complete. I just don't want the ticket to be moved to 2.8 and then forget during the time that I'm not actively on inline documentation.
jacobsantos — 5 years ago
Completion and fixes for base file inline documentation based off of r8947
comment:18
azaozz — 5 years ago
- Resolution set to fixed
- Status changed from reopened to closed
comment:19
jacobsantos — 5 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
More corrections for comment.php
comment:20
azaozz — 5 years ago
- Resolution set to fixed
- Status changed from reopened to closed
comment:21
jacobsantos — 5 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Patch completes new functions for comment-template.php. I would leave this ticket open because the patch after this will actually fix the @since phpdoc tags with the version numbers the code was introduced in.
comment:22
ryan — 5 years ago
comment:23
jacobsantos — 5 years ago
New patch for file level inline documentation for default themes and plugins (Akismet patch has been sent up stream to plugins.trac.wordpress.org).
jacobsantos — 5 years ago
comment:24
westi — 5 years ago
comment:25
westi — 5 years ago
comment:26
westi — 5 years ago
comment:27
westi — 5 years ago
I think that covers all those changes.
Also merged the BackPress ones upstream - http://backpress.automattic.com/changeset/154
comment:28
ryan — 5 years ago
jacobsantos — 5 years ago
Fixes for setup-config.php to keep from poisoning the defines in wp-config-sample.php, based off of r9124
comment:29
jacobsantos — 5 years ago
- Keywords close-2.7 added
comment:30
westi — 5 years ago
comment:31
jacobsantos — 5 years ago
- Resolution set to fixed
- Status changed from reopened to closed
Thanks!
Closing as fixed for 2.7. Any other corrections could probably wait for 2.8. There needs to be other testing to ensure that duplicate functions / constants / globals aren't poisoning the completed documented functions / constants / globals. That is quite a huge project, so should probably be done for 2.8.

Corrections for TinyMCE Spellchecker plugin for adding @package phpdoc tags, based off of r8674