Ticket #7789 (closed defect (bug): fixed)

Opened 3 years ago

Last modified 3 years ago

Add new link fails silently

Reported by: tellyworth Owned by: anonymous
Priority: normal Milestone: 2.7.1
Component: General Version: 2.7
Severity: normal Keywords: has-patch tested
Cc:

Description

This might be a dupe but I couldn't find anything in search. Steps to reproduce:

  1. Go to Manage / Links / Add New Link
  1. Enter a URL in the web address box. Leave the Name box blank.
  1. Click the Save button.

Expected: either the link should get added with a default name, or there should be an error message.

Actual: silent failure. No error message or feedback, and the link is not added. The Add New page gets displayed again, which is exactly the same behaviour that happens when a links is added successfully.

Fix: There should be feedback (both positive and negative) after clicking Save. I'd also suggest changing it so that URL is the only require field; a default name could be derived from that.

Tested in trunk but I think this fails in earlier versions also.

Attachments

7789.diff Download (587 bytes) - added by Denis-de-Bernardy 3 years ago.

Change History

comment:1   mrmist — 3 years ago

  • Keywords needs-patch added
  • Milestone changed from 2.8 to 2.7.1

Denis-de-Bernardy — 3 years ago

comment:2   Denis-de-Bernardy — 3 years ago

  • Keywords has-patch tested added; needs-patch removed

comment:3   ryan — 3 years ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [10414]) If link name not given, use url for name. Props Denis-de-Bernardy. fixes #7789 for trunk

comment:4   ryan — 3 years ago

(In [10415]) If link name not given, use url for name. Props Denis-de-Bernardy. fixes #7789 for 2.7

Note: See TracTickets for help on using tickets.